-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad L parameter #549
Comments
Same here. Logging seems to be messed up this release. One Line has more than 3mb! |
RealURL also seems to ignore [SYS][systemLogLevel]. Errors get written in TYPO3-Log even [SYS][systemLogLevel] was set to only log fatal errors. |
@responseinformationsdesign |
Same here |
We have the same situation after upgrading realurl to 2.3. |
Typo3 - 6.31
I did not get that. Could you please try in other words? |
@Batman777
|
Awesome .. thank you. Hope this works! :-) |
This morning the site was online. This afternoon i got a white page. Log file gives me the following error: After removing the snippet you send me yesterday the site is online again. But now the log file is growing every minute again :-( |
Sorry, the snippet I send you was for TYPO3 7.6 upwards. I checked again in one of my 6.2 projects. That's what I put into AdditionalConfiguration.php:
This works since weeks. |
Thank you very much again :-) |
Thank you guys for help, especially Hannes! I went into trouble too with huge, few GB log. |
Actually it resolves (in T3 7.6) problem with lot of DEBUG entries, caused by every view, but if there is somewhere in the world strange link to our page with bad L parameter then Google will index the whole site since this bad L parameter will glue to every single link. Then lot of ERROR labeled entries will go to the log file. And voila, you have again few GB in few minutes: |
As an other workaround for TYPO3 7.6 and above, you can add this to your AdditionalConfiguration.php:
or change the writer configuration just for the Realurl-Url-Encoder class:
Additionally, if your side doesn't use multiple languages, you could also remove the
If you use other linkVars, of course you should leave them as before. |
Thank you, @mediaessenz ! |
Looks like it works :) |
I am also experiencing this problem in TYPO3 7.6. Server eventually ran out of space and crashed due to a 60GB Log file full of these RealURL Errors. I have L(0-6) set in my config since I only have those languages, but I see requests for L=10/11/12 and so on coming from outside. Probably Searchengine or bot trying languages. |
The huge logs are generated from here: https://github.com/dmitryd/typo3-realurl/blob/development/Classes/Encoder/UrlEncoder.php#L1589 |
I made this rewrite rule for .htaccess to remove unwanted L parameters: Play with the regex: https://regex101.com/r/KsOYvR/1 In this case I allow only L=1 and L=11. |
#551 fixes the Logfile overflow. |
@webian And what if u have partial translated content? |
@fazzyx sorry I can't understand what you're asking. Can you explain your doubts further? |
@webian Basically you translate to another language, but not every content / site. |
@fazzyx my rewrite rule should be used to remove L parameter with values not configured. Does your case have urls with values for L parameter not configured? |
@webian I just described a scenario where not every content or page are translated. You have only a workaround more, but we need a solution. |
we were able to stop the logging with TypoScript |
There's a typical issue with bootstrap_package : you need to disable unneeded languages in the template constants - cf. this other thread : |
@outdoorsman Did you get the 2.3.1 from TYPO3 TER or directly from github ? I made the update from the TER but i'm still getting huge log files... |
2.3.1 does not contain the fix: 2c66992#commitcomment-26436691 |
When I first updated it, it seemed to keep spewing log files that went in the the gigabytes within minutes. But if I remember right (and I'm not sure about this), I cleared cache from the TYPO3 backend and it didn't work but then cleared them from the Install Tool which I believe does it much more thoroughly and then it reduced down to single line entries instead of a full trace... at least manageable if you don't leave it too long. I used the Development branch from... https://github.com/dmitryd/typo3-realurl.git. You should be in Production/Live mode too. |
I do not understand the wiki page
If I use the TYPO3 backend to search for a term "courier-authlib-0.59.1-1.x86_64", then I have no result. |
@adrienjacob Thanks for that tip about the above issue in bootstrap_package. Unfortunately the fix you mentioned only works for version 7.1.0 and above and I have bootstrap_package version 7.0.5. It's also in a complicated integration so I can't just update it quickly. |
No. Links are generated to TYPO3 and only passed to realurl to encode to speaking url. So if TYPO3 makes |
The fix suggested by @adrienjacob solved my problem. |
I'm using also the workaround mentioned here, but I'm not happy with. Because on our staging system we have the same problem and if we are using the workaround, then we can not set the Debug settings in Installtool to debug. |
@dmitry: Now I did more investigations. I collected the IP addresses of the users who's visits to my website generate those masses of entries into the PHP error_log file by realurl:
Both IP addresses are listed as known for making attempts for DDoS attacks. Do you still continue to think that TYPO3 generated those wrong L parameters? |
/cc @dmitryd |
Same behaviour here on several sites with TYPO3 8.7.9 + RealURL 2.3.1. Most notably on one site with
As a consequence, the log file currently grows by 2 GB/h. Each new line adding >20MB to the log file. I think that's not acceptable in a production environment... |
I had the same impression in the past, but found the actual root cause of the problem on our website. The stack trace in the log messages were actually a real help to find this bug. |
Would it make sense for something like the |
Yeah sure, removing the need for such outdated extensions would also reduce the possible attack vectors. |
+1 |
Is it possible to lockdown 2.3.1 and 2.3.0? At this point we have to set a fix version in every composer.json... This is a serious bug and will "DDOS" the system itself... |
This has taken down an entire server full of websites multiple times. After some work I have been able to reduce the amount of logs but they are still filling up with imaginary errors as far as I can tell. The default should not be to blow up the system with logs like this, maybe you can add a debug checkbox mode to the extension or something but when in production this shouldn't happen! |
Same problem here, logs are filling up my server disk constantly and very rapidly. Version 2.3.1 installed. |
If you're using the "bootstrap_package", set correct values for |
May be, you can configure your system correctly after all this? What do you think? ;) These are not imaginary errors but a faulty implementation of your site. |
@co-operate Same for you: configure the site correctly! Your site allows arbitrary |
@dmitryd I thought |
@dmitry as far as I can tell I've followed your advice on how to configure and still get errors. Don't know what to think, but I still say that I've used this extension for years and never had an issue until now, all of a sudden, things are blowing up. I didn't change anything on my end. Then I tried to follow the directions you gave and it though it did reduce things I still couldn't get it to stop slowing filling my logs. I love verbose logging when needed but I still think the default should not be something so verbose that it crashes servers. Please don't take it personally... I'm just sharing one opinion of what would be good practice. I will still use and be grateful for the extension either way. |
If I change the page content, maybe you drop a (multilanguage) page (but not the whole language), there are still entries anywhere outside |
@fazzyx @outdoorsman Read: https://github.com/dmitryd/typo3-realurl/wiki/Notes-for-Integrators#i-see-a-lot-of-strange-entries-in-the-realurl-module This gives instructions what to do. |
I have a single-language page and also get log entries. My Config looks like this: TypoScript-Setup:
realurlconf:
TYPO3 doesn't generate the faulty links, but when i call the page with a faulty L parameter manually the log file is flooded. Worst case: Using a faulty L parameter on a paginated news list page where 25 log entries (250MB) are created on 1 request. Example-URL valid:
Flood the logs:
|
Additional Info: Nevertheless i think there should be an option to disable/shorten the log made by realurl, because there is no easy way to fix this. |
Contradiction here. If log is flooded, it means that TYPO3 called realurl with a wrong |
Hi
When users or bots try to set Language variable to fr
I have this error
Thu, 12 Oct 2017 09:46:25 +0200 [ERROR] request="eb2a025b3e3ec" component="DmitryDulepov.Realurl.Encoder.UrlEncoder": Bad "L" parameter ("fr") was detected by realurl......
Logs are very very very large and saturate my disk
I try to ignore this param with config.linkVars = L(0-1) but it does not work
The text was updated successfully, but these errors were encountered: