Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS on page-cache is possible #160

Closed
rvock opened this issue May 16, 2016 · 4 comments
Closed

DOS on page-cache is possible #160

rvock opened this issue May 16, 2016 · 4 comments
Labels

Comments

@rvock
Copy link
Contributor

rvock commented May 16, 2016

TYPO3 uses the cHash-Parameter to validate URLs and only cache a page, if a valid cHash is found. Otherwise it would be possible to only change a parameter and create a new cache-entry in the database:
www.example.org/en/?test=1
www.example.org/en/?test=2
www.example.org/en/?test=3
www.example.org/en/?test=4

This will generate 4 cache entries, even though there is no valid cHash in the URL. (see https://typo3.org/documentation/article/the-mysteries-of-chash-1/ )

This happens because UrlDecoder::doDecoding calls calculateChash and generates a valid cHash:
https://github.com/dmitryd/typo3-realurl/blob/131ce5c/Classes/Decoder/UrlDecoder.php#L155

@dmitryd
Copy link
Owner

dmitryd commented May 16, 2016

True. This is expected.

Your proposals?.. How do we avoid bad cHash in the following cases if there is no URL cache entry and cHash recalculation:

  • URL with parameters
  • URL with empty parameters that do not get to the URL but affect cHash

@itmdesign
Copy link

Any new information on this subject?

@dmitryd
Copy link
Owner

dmitryd commented Aug 1, 2016

None that I can disclose.

@dmitryd
Copy link
Owner

dmitryd commented Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants