Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockFunction for more concise Function mocking. #25 #26

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

lemonboston
Copy link

Note: this is based on #24 currently (because of ValueObject usage).

@codecov-io
Copy link

codecov-io commented Oct 4, 2017

Codecov Report

Merging #26 into master will decrease coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
- Coverage     83.98%   83.57%   -0.42%     
- Complexity      310      316       +6     
============================================
  Files            70       73       +3     
  Lines           743      767      +24     
  Branches         64       64              
============================================
+ Hits            624      641      +17     
- Misses           96      103       +7     
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
...in/java/org/dmfs/testutils/mocks/MockFunction.java 100% <100%> (ø) 6 <6> (?)
.../src/main/java/org/dmfs/testutils/TestDoubles.java 0% <0%> (ø) 0% <0%> (?)
...s/src/main/java/org/dmfs/testutils/FailAnswer.java 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bde62...f4a90b0. Read the comment docs.

@dmfs
Copy link
Owner

dmfs commented Oct 9, 2017

can this be rebased on master?

@lemonboston lemonboston force-pushed the issues/25-mockfunction branch from 6eb6cc9 to 49bf94d Compare October 11, 2017 17:13
@lemonboston lemonboston changed the base branch from issues/23-iterable-matchers to master October 11, 2017 17:14
@lemonboston lemonboston force-pushed the issues/25-mockfunction branch from 49bf94d to cb90cad Compare October 11, 2017 17:16
@lemonboston
Copy link
Author

Commented here: #25 (comment)

@lemonboston lemonboston force-pushed the issues/25-mockfunction branch 2 times, most recently from cd251e2 to 39592cf Compare October 12, 2017 14:43
@lemonboston lemonboston force-pushed the issues/25-mockfunction branch from 39592cf to 486d235 Compare October 12, 2017 14:55
@lemonboston
Copy link
Author

Finished rewriting MockFunction and its test, squashed and rebased. Ready for review.

@dmfs dmfs merged commit bdbd1cb into master Oct 12, 2017
@dmfs dmfs deleted the issues/25-mockfunction branch October 12, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants