Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support categorical data for pyvinecopulib #13

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Conversation

letmaik
Copy link
Collaborator

@letmaik letmaik commented Nov 12, 2020

During fitting, category values are reindexed as integers starting from 0 and transformed to one-hot vectors. The opposite during generation. Any data type works for categories, including strings.

@dmey dmey self-requested a review November 12, 2020 22:37
Copy link
Owner

@dmey dmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Just created an example -- works great, thanks!

@dmey dmey merged commit 792ebc1 into master Nov 12, 2020
@dmey dmey deleted the letmaik/categorical branch November 12, 2020 22:43
@dmey dmey modified the milestones: 0.4.0, 0.3.0 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants