This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Support execv with UTF16 arguments on Windows #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tux3
force-pushed
the
windows_utf16
branch
2 times, most recently
from
2543d1c to
c00f0ae
Compare
Would previously fail depending on the current codepage.
dmerejkowsky
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would previously fail depending on the current codepage.
Note that on Windows Python2 will happily fail to receive Unicode strings in sys.argv, and Python3 will correctly decode them but of course printing them back to the terminal may show garbage (depending on the current codepage and terminal used).
Fixes #45