This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Made the download aware of the actual returned batch size when using limit #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryansdowning
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Since this package could use some maintaining help I thought I'd offer a review to help get this merged (I also ran into this issue almost immediately when testing out the api).
The changes here look good and the limit now seems to work as intended, great work! I pulled the fork and did some minimal testing of my own and confirmed the functions are working according to expectations.
|
@ryansdowning thank you for the review! |
|
Well done guys! |
|
The people have spoken! Thanks for pushing this forward ryan. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #79 .
Right now the download is not aware that the API can return less elements than requested. This causes the result to be less than expected when the "limit" is higher than the returned size.