Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Travis build output #133

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Improve Travis build output #133

merged 3 commits into from
Oct 30, 2020

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Oct 30, 2020

I took the freedom to play a bit with the Travis config in this repository, as I had a hard time understanding the Travis output in my Behat PR:

  • Register a NullLogger to hide log output in functional tests (Symfony outputs all logs to stderr if no logger is registered)
  • Use Travis code fold helpers to fold output of successful commands
  • Show the PHPCsFixer diff, so it's clear what to fix (without having to install the phar locally)

For now, this includes #128 to avoid rebasing this when that merged is merged.

@wouterj wouterj changed the title Improve Travis build output [WIP] Improve Travis build output Oct 30, 2020
@wouterj wouterj changed the title [WIP] Improve Travis build output Improve Travis build output Oct 30, 2020
dmaicher
dmaicher approved these changes Oct 30, 2020
View reviewed changes
Copy link
Owner

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better 👍 Thanks

@dmaicher dmaicher merged commit c320713 into dmaicher:master Oct 30, 2020
@wouterj wouterj deleted the fix/improve-build branch October 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterj @dmaicher