Add AdminInterface::setContractTranslator method #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @franmomu thanks for suggesting this. Adding a new method might also be a nice approach to avoid BC 😊 But generally it seems unclear if full support for Symfony 5 on SonataAdminBundle 3.x is wanted? At least that's my impression from all the comments on different PRs 😕 |
|
Although I think I personally would go for the |
dmaicher
pushed a commit
that referenced
this pull request
Apr 23, 2022
Fixes Twig\Error\RuntimeError: nl2br(): Passing null to parameter #1 ($string) of type string is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dmaicher, haven't fully tried, but what about adding another method (I called it
setContractTranslatorfor instance) and call this method from the compiler pass? I haven't change theAdminTestclass, this is just to see if this would work.