Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option "Group_Leds" to group LEDs for increased performance. #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

macadamiaz
Copy link

No description provided.

Added option "Group_Leds" to group LEDs for increased performance.
Added info about LED grouping
@dmadison
Copy link
Owner

dmadison commented Nov 4, 2024

Hi! Thanks for the PR. I like the concept but I'm not fond of the implementation. If you're willing to rewrite it to use a macro to set the group and then copy the data when the LEDs are latched rather than when the byte stream is read I'd be happy to merge it.

@macadamiaz
Copy link
Author

...If you're willing to rewrite it to use a macro to set the group and then copy the data when the LEDs are latched rather than when the byte stream is read I'd be happy to merge it.

I basically just hacked it in, as i'm not proficient at all in FastLED / Arduino / C. So what you're asking is way beyond my knowledge. If you or anyone wants to improve the implementation i'd appreciate it!

However, as it is i'm using it daily with a 232 LED Strip and getting a very high framerate / smoothness with it (which wasn't possible without grouping), so it does actually work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants