Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank games list after login -2 #73

Open
zDEFz opened this issue May 24, 2024 · 27 comments
Open

blank games list after login -2 #73

zDEFz opened this issue May 24, 2024 · 27 comments

Comments

@zDEFz
Copy link

zDEFz commented May 24, 2024

provide a log with steam-tui 2> error.log

Closing because it seems like the initial error was fixed. Also added custom scripts to help with executables being off

Originally posted by @dmadisetti in #62 (comment)

I did do that, but the error.log is absolutely empty!

@dmadisetti
Copy link
Owner

Woops. Thought I responded to this. Are you getting blank games or is the caching screen stuck?

Try flushing cache by removing ~/.cache/steam-tui/*

@zDEFz
Copy link
Author

zDEFz commented May 25, 2024

Okay, I did that. Same behavior!

So after flushing, I was not logged in, so I pressed l to sign in, and confirmed with enter.
After that, I see just a blank list!

But now we got one entry in error.log:

steamcmd.sh[3073582]: Restarting steamcmd by request...

I then ran steamcmd again, and logged in, then I ran the latest git build again, and logged in.
List is empty

Then I relaunched it, logged in again, and now suddenly I got a list, and it even found installed games!
But... the error.log doesnt contain anything new!
A bit unfortunate that the games launching that were set to proton do not launch in the same context and instead try baseline wine.

@dmadisetti
Copy link
Owner

Cool! So can we close this out? What system/ shell do you use though? This is still weird.

You can now write a script to do the launching yourself with proton. Or you can just replace wine with proton here

"wine".to_string(),

Thinking more on windows support, we'll probably have to change launching with wine (no need on windows!)- so maybe we can make the launcher configurable. But let's make a dedicated issue for that

@zDEFz
Copy link
Author

zDEFz commented May 25, 2024

Cool! So can we close this out?

That would be no good choice.
So far, the experience had been inconsistent.
Remember how much effort you put into this project
People might deem it broken and never enjoy it, before they jump through the hoops...

We need to have better error / issue handling.

What system/ shell do you use though? This is still weird.

I do use zsh with zimfw defaults

@CabalCrow
Copy link

Blank list of games for me as well. I do not get any errors though.

@dmadisetti
Copy link
Owner

Can you try off zsh? I can't fix this if I can't replicate it

@CabalCrow
Copy link

I'm on zsh

@dmadisetti
Copy link
Owner

OK- good to have some commonality. Can you try bash on xterm?

@CabalCrow
Copy link

same result

@chimps-ahoy
Copy link

I'm on bash/dash (/bin/sh is dash but I used bash interactively, not sure what this program calls on), in st terminal and getting the same behaviour along with no error outputting when I try to make a log file.

@dmadisetti
Copy link
Owner

Cool, so windows verifiably breaks without logging because line character endings are weird. I'm wondering if whatever steamcmd versions you are using have a similar response.
I just pushed something that adds logging around the problematic area.

If you could respond with your steamcmd version and an error log from "steam-tui 2> error.log" after building the source, that would go a long way.

dmadisetti added a commit that referenced this issue May 31, 2024
@CabalCrow
Copy link

what is the command for building from source?

@dmadisetti
Copy link
Owner

cargo build https://doc.rust-lang.org/cargo/getting-started/installation.html

How are you currently getting steam-tui? arch?

@CabalCrow
Copy link

the AUR

@CabalCrow
Copy link

Seems to work when building from source - the problem is likely in the aur package.

@dmadisetti
Copy link
Owner

Ok cool. The AUR release commit was borked. I just repushed. Please try from AUR now.


This ended up being a pretty easy fix- so sorry about all the back and forth.

What do you think could have made the process go easier?
Once I guessed it was an issue with AUR, it was pretty easy to find the problem

  • Should I make a PR template?
  • Should I have a standard copy pasta for asking for debugging issues?

please give some feedback, because this was needlessly drawn out

@CabalCrow
Copy link

Having the standard copy pasta asking for package version & OS, would probably help in this case.

@Ciflire
Copy link

Ciflire commented Jun 5, 2024

Same error here when building from flake

@zDEFz
Copy link
Author

zDEFz commented Jun 6, 2024

It appears that running steamcmd manually can help sometimes...
But it's super annoying.

@dmadisetti
Copy link
Owner

So it's not AUR, and there are no debug logs? Even with the latest commit? I don't know what more I can do, because I cannot replicate

@Ciflire
Copy link

Ciflire commented Jun 6, 2024

would love to provide debug logs if you tell me how to

@dmadisetti
Copy link
Owner

steam-tui 2> error.log

@Ciflire
Copy link

Ciflire commented Jun 6, 2024

error.log
I'm sorry i don't think that gonna be helpful

@zDEFz
Copy link
Author

zDEFz commented Jun 6, 2024

So it's not AUR, and there are no debug logs? Even with the latest commit? I don't know what more I can do, because I cannot replicate

I think what happens is that when steam is launched, it re-validates the user and invokes steamcmd and gets some kind of token.

When steam-tui is being ran, it doesn't first invoke steam to check if we are up-to-date and what not.
My guesses:

When a update is available on steam

  • The list may still be there from one time it worked, but no game appears as installed

When the user tried on a bad connection or on VPN

  • Then the authentication for the login may be revoked

And yes. the log is absolutely empty!

The following I have to do each time:

  1. steamcmd login ... for auth
  2. remove steam-tui caches
  3. steam-tui ... r for reload
  4. steam-tui will hang, need to press q/ctrl+c
  5. start steam-tui again and press r again, then exit
  6. start steam-tui yet another time
  7. game list appears with installed games

@zDEFz
Copy link
Author

zDEFz commented Jun 6, 2024

My suggestions:

  1. If never ran - then start steamcmd beforehand for initial auth.
  2. Download and install the last steam update programmatically (like steam itself would)
  3. Remove/Clear caches programmatically
  4. Revalidate login token/auth

Step 3 might prompt the user to login again, or its possible to re-use the cookie or something.

@dmadisetti
Copy link
Owner

The log actually looks very useful, steam version is embedded and we know that at least "info" was invoked. I'll take another look at it this weekend. If others can provide logs that would also be useful.

@zDEFz I will try that

@monandszy
Copy link

Issue still present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants