Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(RESTClient): add hint about connection pooling #2160

Closed
wants to merge 2 commits into from

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Dec 17, 2024

No description provided.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit a18cc33
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67619f1127ecd900083f48a7
😎 Deploy Preview https://deploy-preview-2160--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joscha
Copy link
Contributor Author

joscha commented Dec 17, 2024

I actually just found

max_connections: int = 50,
- unsure why the performance is different to my current pooling, need to investigate.

Update: most likely because the code I have is creating multiple instances of RESTClient, each with their own session.

Update 2: yes, by capturing the very first session of any created default RESTClient and passing it on to any that subsequently gets created I was able to achieve the same performance.

@joscha joscha closed this Dec 17, 2024
@joscha joscha deleted the patch-1 branch December 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant