Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document that path can also be a URL #2099

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Nov 26, 2024

via @burnash in #2082 (comment)

As for the base_url, I'm not sure it's necessary within the resource configuration since endpoint.path can accept an absolute URL (I'd need update the documentation to reflect this). Putting headers and auth into the endpoint configuration would make it consistent with how the underlying RESTClient and RESTClient.paginate operate.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 708c96e
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67451fc3c82d3f0008b76e27
😎 Deploy Preview https://deploy-preview-2099--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @joscha, thank you for the contribution!

@burnash burnash merged commit d9cdc6c into dlt-hub:devel Nov 26, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants