Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Ollama Host #2044

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

Pipboyguy
Copy link
Collaborator

Description

This makes the ollama host, as well as other providers' hosts, configurable with

os.environ["DESTINATION__LANCEDB__EMBEDDING_MODEL_PROVIDER_HOST"] = "http://192.168.192.3:11434"

Related Issues

@Pipboyguy Pipboyguy self-assigned this Nov 9, 2024
@Pipboyguy Pipboyguy linked an issue Nov 9, 2024 that may be closed by this pull request
@Pipboyguy Pipboyguy requested review from rudolfix and akelad November 9, 2024 20:53
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 61ee305
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/672fcd553bf0c400085c6acd
😎 Deploy Preview https://deploy-preview-2044--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akelad
Copy link
Contributor

akelad commented Nov 11, 2024

looks great from my side, will leave Marcin to do the actual code review :)

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit f13e3f1 into devel Nov 25, 2024
60 of 61 checks passed
@rudolfix rudolfix deleted the 1973-lancedb-destination-with-ollama-embedding branch November 25, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LanceDB destination with Ollama embedding
3 participants