Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structural and content changes to the sql_database doc #1623

Merged
merged 14 commits into from
Sep 12, 2024
Merged

structural and content changes to the sql_database doc #1623

merged 14 commits into from
Sep 12, 2024

Conversation

rahuljo
Copy link
Contributor

@rahuljo rahuljo commented Jul 23, 2024

No description provided.

@rahuljo rahuljo requested review from VioletM and akelad July 23, 2024 08:59
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit f17416d
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66e2d49b88c4b50009dc74a7
😎 Deploy Preview https://deploy-preview-1623--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

VioletM
VioletM previously requested changes Aug 12, 2024
View reviewed changes
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated Show resolved Hide resolved
@VioletM VioletM linked an issue Aug 22, 2024 that may be closed by this pull request
Docs | sql_database makeover #1718
Closed
4 tasks
@sh-rp
Copy link
Collaborator

sh-rp commented Sep 2, 2024

One comment from my side: we are missing the info about being able to change the sqlalchemy query in a callback for filtering, ordering and sorting.

@sh-rp sh-rp added the documentation Improvements or additions to documentation label Sep 2, 2024
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Sep 2, 2024
@akelad
Copy link
Contributor

akelad commented Sep 3, 2024

@sh-rp we can add that, but tbh that should have happened from the developer that initially implemented it, right?

@rahuljo rahuljo requested a review from mariarice15 September 10, 2024 15:14
@rahuljo rahuljo dismissed VioletM’s stale review September 12, 2024 07:54

Already updated the PR with all the suggestions

@rahuljo rahuljo requested a review from mariarice15 September 12, 2024 07:56
mariarice15
mariarice15 previously approved these changes Sep 12, 2024
View reviewed changes
akelad
akelad previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so you can merge once it builds

@rahuljo rahuljo merged commit 0baebde into devel Sep 12, 2024
49 checks passed
@rudolfix rudolfix deleted the docs/modify-sql-verified-source-doc branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletM VioletM VioletM left review comments

@akelad akelad akelad approved these changes

@mariarice15 mariarice15 mariarice15 left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation sprint Marks group of tasks with core team focus at this moment
Projects
dlt core library
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs | sql_database makeover
6 participants
@rahuljo @sh-rp @akelad @VioletM @mariarice15 @rudolfix