Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SUGGESTION_SELECTED event and fix multiple commit calls #82

Conversation

leewyatt
Copy link
Contributor

@leewyatt leewyatt commented Aug 22, 2023

This pull request addresses two primary concerns:

  1. Introduction of SUGGESTION_SELECTED Event: (Add event which gets fired when the SearchField has commited #69 )

    • A new event type, SUGGESTION_SELECTED, has been added to the SearchEvent class.
    • This event is fired when a user selects a suggestion, providing more granular control over the suggestion selection process.
    • field.addEventHandler(SearchField.SearchEvent.SUGGESTION_SELECTED, event -> { System.out.println("A suggestion was selected! => " + event.getSelectedSuggestion()); });
  2. Fix for Multiple Commit Calls: (SearchField - commit gets called 3 times when an item is selected #60 )

    • Identified and fixed an issue where the commit method was being invoked multiple times during a single suggestion selection.
    • Streamlined the process to ensure that the commit method is only called once per suggestion selection.

@dlemmermann dlemmermann merged commit bcfe0bb into dlsc-software-consulting-gmbh:master Aug 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants