Add ability to reset CalendarPicker value to null #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leewyatt
commented
Jul 12, 2024
leewyatt
commented
- Allow the CalendarPicker to reset its value to null, enabling the user to indicate no date selection.
- Unable to reset the date to null in the CalendarPicker #196
- Allow the CalendarPicker to reset its value to null, enabling the user to indicate no date selection.
The value binding for the CalendarPicker's text property is revised to handle null cases. Previously, there was no check for a null value which could have caused issues when no date was selected. Now, when the value is null, it displays "No Date Selected". Also, the order of the UI elements in the VBox has been adjusted for a better user experience.
|
dlemmermann
requested changes
Jul 13, 2024
| @@ -26,7 +26,7 @@ public void start(Stage stage) { | |||
| calendarPicker.setValue(LocalDate.now()); | |||
|
|
|||
| Label valueLabel = new Label(); | |||
| valueLabel.textProperty().bind(Bindings.createStringBinding(() -> calendarPicker.getConverter().toString(calendarPicker.getValue()), calendarPicker.valueProperty())); | |||
| valueLabel.textProperty().bind(Bindings.createStringBinding(() -> calendarPicker.getValue() == null ? "No Date Selected" : calendarPicker.getConverter().toString(calendarPicker.getValue()), calendarPicker.valueProperty())); | |||
There was a problem hiding this comment.
I am not a fan of having messages like that because it requires internationalisation.
dlemmermann
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.