Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Performance sample app I switched to week view and created a single entry.
When I am dragging and dropping this entry like a very nervous person I managed to leave back "ghosts" of the entry. Also when dragging/dropping the start or end time very nervous I saw some NPEs in the console.
This patch fixed all of these issues.
It came down to the fact that it is possible that you get mouseMoved events before the mouseReleased event even in drag mode.
In this case the initDragModeAndHandle set the dragMode to null too early and it looked like as if there was no dragging action active at all.
I also saw mouseDragged before mousePressed.
This patch introduces a boolean "dragging" which is set and unset in mousePressed/mouseReleased and, as long as this boolean is true, in mouseMoved the dragMode will not be reset.
I hope I was able to describe the issue good enough.
Java: Java 1.8.0_152-ea-b05
OS: macOS 10.13