Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since Angular 10 migration: creating new libraries fails with missing tsconfig.base.json #33

Closed
MichaelLangbein opened this issue Aug 5, 2020 · 0 comments · Fixed by #34
Assignees
Labels
bug fix: (Something isn't working)

Comments

@MichaelLangbein
Copy link
Collaborator

Describe the bug

With the current master branch, executing

npx ng generate library <library-name>

fails with the error-message:

Cannot find base TypeScript configuration file 'tsconfig.base.json'.

A little research brought up evidence that others, too, have experienced a similar issue, and - with a little luck - a way to resolve it. In short, it seems that angular's update did not separate our tsconfig.json into a tsconfig.base.json (which all projects inherit from) and a stub tsconfig.json (which seems to only remain there for the sake of IDE's like VSCode).

I'll attempt to properly split our config in those two files.

To Reproduce

From the root-directory, run

npx ng generate library <library-name> (--dry-run)

Expected behavior

Putting it a little matter-of-fact-ly: generating libraries should work.

Versions

App

  • Angular: [10.0.8]
  • Node: [v12.13.0]
  • Clarity: [3.1.5]
  • UKIS: [7.1.0]

Device:

  • Type: [Notebook]
  • OS: [Windows]

Additional context

As a side note, this issue only occurs when generating libraries. I didn't encounter any errors in e.g. generating components - which makes sense, since new components don't need a new tsconfig-file.

@MichaelLangbein MichaelLangbein added the bug fix: (Something isn't working) label Aug 5, 2020
@MichaelLangbein MichaelLangbein self-assigned this Aug 5, 2020
MichaelLangbein pushed a commit that referenced this issue Aug 5, 2020
@MichaelLangbein MichaelLangbein mentioned this issue Aug 5, 2020
14 tasks
@MichaelLangbein MichaelLangbein linked a pull request Aug 5, 2020 that will close this issue
14 tasks
boeckMt pushed a commit that referenced this issue Aug 7, 2020
* build: created a tsconfig.base.json, to be used as the basis for new libraries. Handles issue #33

* build: made all projects extend tsconfig.base.json

* build: made all project's tests extend tsconfig.base.json

* docs: documented the new tsconfig.base.json

* refactor: updated files to conform to angulars defaults when setting up a new project

* refactor: added actual projects to tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix: (Something isn't working)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants