Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SourceComments including stdin instead of proper file path #286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aphex
Copy link

@aphex aphex commented May 25, 2015

Resolves #234

@Keats
Copy link
Collaborator

Keats commented Jun 9, 2015

sorry for the wait, could you add a test that was previously failing for that to the testsuite?

@Snugug
Copy link
Collaborator

Snugug commented Jun 24, 2015

Yes, please add a test for this.

I'm also concerned that passing the file to Node Sass may result in unintended consequences of the raw file being compiled instead of the contents of the file stream. We already have a place in our codebase to transform stdin in to the main file's path (for sourcemaps); please refer to that,

@Snugug Snugug added this to the 2.1.0 milestone Jun 24, 2015
@Snugug
Copy link
Collaborator

Snugug commented Jul 14, 2015

With the fix in #314, this is now failing. Can you please update?

@xzyfer xzyfer force-pushed the master branch 13 times, most recently from 5c3ead2 to cc4ed2f Compare March 11, 2018 05:37
@XhmikosR
Copy link
Contributor

XhmikosR commented Dec 29, 2021

@xzyfer are you still interested in this? I rebased it, but unsure if you want to land it: master...XhmikosR:pr/286

@XhmikosR XhmikosR mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourceComments option gets ignored if called by gulp.watch
4 participants