Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create failing test, address #278 #282

Closed
wants to merge 1 commit into from

Conversation

neagle
Copy link

@neagle neagle commented May 21, 2015

Thanks for giving me the green light to create a pull request. After running my suggested fix through the test suite, I'm no longer sure what the right way to fix this is: my suggestion breaks some other cases.

Instead, I created a test that fails when given the conditions I described in my issue. Hopefully this makes things as clear as possible so that someone with more experience on the project than I have can suggest something.

Please let me know what else I can supply from my end: I'd definitely like to do whatever possible to help fix the problem for my use-case.

@Snugug Snugug closed this in 2a4f945 Jul 15, 2015
@Snugug
Copy link
Collaborator

Snugug commented Jul 15, 2015

Moved your tests in by hand. Had to update neagle@4690842#diff-e5b8495db5b34b144973178386ba5ceeR426 because it was producing the wrong file name for the subdirectory file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants