Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#41] Fix start direction infinite scroll not work when threshold is 0 #42

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

dlguswo333
Copy link
Owner

@dlguswo333 dlguswo333 commented Nov 24, 2024

Closes #41 .
If visibleStartIndex is 0, it means the first item appears inside the window and it is time to load more items.

@dlguswo333 dlguswo333 added the bug Something isn't working label Nov 24, 2024
@dlguswo333 dlguswo333 self-assigned this Nov 24, 2024
@dlguswo333 dlguswo333 force-pushed the feature/#41 branch 3 times, most recently from 0c12ba3 to 54d2f78 Compare November 24, 2024 09:29
@dlguswo333 dlguswo333 merged commit e906247 into main Nov 24, 2024
1 check passed
@dlguswo333 dlguswo333 deleted the feature/#41 branch November 24, 2024 10:31
dlguswo333 added a commit that referenced this pull request Nov 24, 2024
#42
Setting threshold to 0 may not disable calling loadMoreItems.
Use less strict word to clarify the point.
dlguswo333 added a commit that referenced this pull request Nov 24, 2024
#42
Setting threshold to 0 may not disable calling loadMoreItems.
Use less strict word to clarify the point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix infinite scroll on 'start' direction not work when scrollOffset > 0 && threshold === 0
1 participant