Added Motion Blur #105
Merged
Added Motion Blur #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemstra
reviewed
Jul 27, 2023
src/magick-image.ts
Outdated
| @@ -205,6 +205,8 @@ export interface IMagickImage extends IDisposable { | |||
| modulate(brightness: Percentage): void; | |||
| modulate(brightness: Percentage, saturation: Percentage): void; | |||
| modulate(brightness: Percentage, saturation: Percentage, hue: Percentage): void; | |||
| motionBlur():void; | |||
| motionBlur(radius?: number, sigma?: number, angle?: number): void; | |||
There was a problem hiding this comment.
All these numbers should be mandatory in this overload.
src/magick-image.ts
Outdated
| @@ -205,6 +205,8 @@ export interface IMagickImage extends IDisposable { | |||
| modulate(brightness: Percentage): void; | |||
| modulate(brightness: Percentage, saturation: Percentage): void; | |||
| modulate(brightness: Percentage, saturation: Percentage, hue: Percentage): void; | |||
| motionBlur():void; | |||
There was a problem hiding this comment.
Can you please remove this overload? The user will always need to specify the values. In ImageMagick the last value is not mandatory but I don't want to create a specific overload for this. And this overload is also not available in the Magick.NET api and I am trying to keep this library as close as possible to the Magick.NET library.
|
|
||
| import { IMagickImage, MagickImage } from '../../src/magick-image'; | ||
|
|
||
| let image: IMagickImage; |
There was a problem hiding this comment.
You don't need this anymore. You can use TestImages.Builtin.logo.use((image) => { in the unit test instead.
|
Thanks for CR, i pushed updated version with all your notes implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank u for your work. It is awesome! Could u pls add this feature to your branch? Thanks :)