Parse unittest attributes and write them to the publictest tester #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
force-pushed
the
unittest-attributes
branch
from
afdcdc4
to
cee8eda
Compare
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + tools#369" |
|
(passing on TravisCI now - AppVeyor failure is unrelated.) |
thewilsonator
approved these changes
May 14, 2019
PetarKirov
reviewed
May 15, 2019
| if (!predefinedAttributes.canFind(atText)) | ||
| continue; | ||
|
|
||
| outFile.write(text("@", atText, " ")); |
There was a problem hiding this comment.
I don't think this would work with attributes whose syntax doesn't start with @ , like pure and nothrow
There was a problem hiding this comment.
Yup, but DScanner treats these guys differently:
$ dscanner --ast foo.d | xmllint --format -
<?xml version="1.0"?>
<module>
<declaration>
<attribute attribute="pure"/>
<attribute>
<atAttribute>
<identifier>safe</identifier>
</atAttribute>
</attribute>
<unittest>
<blockStatement>
</blockStatement>
</unittest>
</declaration>
</module>
There was a problem hiding this comment.
But yeah it's probably a good idea to extract these guys too while we're at it: #371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the underlying issue is https://issues.dlang.org/show_bug.cgi?id=19873, fixing this allows the Phobos PR to move on for now.
tl;dr: the publictest extractor now extracts the respective system attributes too.
Required for dlang/phobos#6931