Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla 24685 - std.stdio.File.rawRead allows reading raw pointe… #9030

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jul 26, 2024

…rs from files in @safe code

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24685 major std.stdio.File.rawRead allows reading raw pointers from files in @safe code

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9030"

@ntrel
Copy link
Contributor Author

ntrel commented Jul 26, 2024

Rebased but buildkite style check still failing with warnings about std.range. And ldc CMake error now too.

@thewilsonator thewilsonator merged commit 4d54884 into dlang:master Jul 26, 2024
9 of 10 checks passed
RubyTheRoobster pushed a commit to RubyTheRoobster/phobos that referenced this pull request Aug 6, 2024
RubyTheRoobster pushed a commit to RubyTheRoobster/phobos that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants