-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable function attributes dscanner check #8648
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @lucica28! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8648" |
@@ -46,7 +46,7 @@ logical_precedence_check="enabled" | |||
; Checks for undocumented public declarations | |||
undocumented_declaration_check="enabled" | |||
; Checks for poor placement of function attributes | |||
function_attribute_check="enabled" | |||
function_attribute_check="disabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to disable this entirely? It seems that this check applies to other attributes (@safe, nogc etc.) as well.
Well I attempted that, but there are just situation where I'm not 100% sure the check is correct. We can have |
You can partially disable the check in D-Scanner as well |
It should probably be |
@lucica28, are there other cases (apart from If you decide to fix the warnings, I suggest you push your changes to this PR (and rename it), to keep the context consolidated for reviewers. |
I think this check should be disabled for now, because it does not work as expected. A very brief example:
I fixed that issue in my fork of
D-Scanner
, but I can't really move forward until this check is disabled, because one ofD-Scanner
's tests is to apply it tophobos
and have 0 warnings, but I'm getting a lot of warnings from constructions like the second expression mentioned in the example. After I will be done with my project I will probably take the time and fix the warningsD-Scanner
throws when applied tophobos
, but this is a significant effort, and for now it would be really helpful to disable this check in order to be able to move forward with my project(https://github.com/Dlang-UPB/D-scanner)