-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve expi() documentation issues due to deprecation. #7207
Conversation
Sync with upstream.
Fixes issue 19733 https://issues.dlang.org/show_bug.cgi?id=19733 Nowadays, the x87 instruction fsincos is slower, not faster, than computing sin and cos separately. https://stackoverflow.com/questions/12485190/calling-fsincos-instruction-in-llvm-slower-than-calling-libc-sin-cos-functions Therefore, there is no need for assembly in the expi() implementation, which was removed in commit 029440c.
Thanks for your pull request and interest in making D better, @veelo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7207" |
Please amend the commit message to say "Fix issue 19733: ..." so the bot picks it up. |
Will try. |
Fix issue 19733: https://issues.dlang.org/show_bug.cgi?id=19733 Nowadays, the x87 instruction fsincos is slower, not faster, than computing sin and cos separately. https://stackoverflow.com/questions/12485190/calling-fsincos-instruction-in-llvm-slower-than-calling-libc-sin-cos-functions Therefore, there is no need for assembly in the expi() implementation, which was removed in commit 029440c.
As stated in bugzilla, I saw a significant boost (~5x faster) with the x87 asm version with LDC on my i5-3550. The linked StackOverflow question isn't related to 80-bit |
@kyllingstad For what reasons was the x87 asm version removed from std.complex.expi? 029440c |
See discussion in PR #559, in particular Don's comment |
Just noticed this - I wrote a similar PR yesterday, which is meanwhile merged. Hence, this PR can be closed. ("Having Fix - issue 19733 [...]" in the commit message would have maked the bot adding a link to this PR in bugzilla and I would have known of it earlier.) |
Fix issue 19733: https://issues.dlang.org/show_bug.cgi?id=19733
Nowadays, the x87 instruction fsincos is slower, not faster, than computing sin and cos separately.
https://stackoverflow.com/questions/12485190/calling-fsincos-instruction-in-llvm-slower-than-calling-libc-sin-cos-functions
Therefore, there is no need for assembly in the expi() implementation, which was removed in commit 029440c.