Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve expi() documentation issues due to deprecation. #7207

Closed
wants to merge 4 commits into from

Conversation

veelo
Copy link
Contributor

@veelo veelo commented Oct 1, 2019

Fix issue 19733: https://issues.dlang.org/show_bug.cgi?id=19733

Nowadays, the x87 instruction fsincos is slower, not faster, than computing sin and cos separately.
https://stackoverflow.com/questions/12485190/calling-fsincos-instruction-in-llvm-slower-than-calling-libc-sin-cos-functions
Therefore, there is no need for assembly in the expi() implementation, which was removed in commit 029440c.

veelo and others added 2 commits October 1, 2019 11:19
Fixes issue 19733 https://issues.dlang.org/show_bug.cgi?id=19733

Nowadays, the x87 instruction fsincos is slower, not faster, than computing sin and cos separately.
https://stackoverflow.com/questions/12485190/calling-fsincos-instruction-in-llvm-slower-than-calling-libc-sin-cos-functions
Therefore, there is no need for assembly in the expi() implementation, which was removed in commit 029440c.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @veelo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7207"

@thewilsonator
Copy link
Contributor

Please amend the commit message to say "Fix issue 19733: ..." so the bot picks it up.

@veelo
Copy link
Contributor Author

veelo commented Oct 1, 2019

Please amend the commit message to say "Fix issue 19733: ..." so the bot picks it up.

Will try.

Fix issue 19733: https://issues.dlang.org/show_bug.cgi?id=19733

Nowadays, the x87 instruction fsincos is slower, not faster, than computing sin and cos separately.
https://stackoverflow.com/questions/12485190/calling-fsincos-instruction-in-llvm-slower-than-calling-libc-sin-cos-functions
Therefore, there is no need for assembly in the expi() implementation, which was removed in commit 029440c.
@kinke
Copy link
Contributor

kinke commented Oct 1, 2019

As stated in bugzilla, I saw a significant boost (~5x faster) with the x87 asm version with LDC on my i5-3550. The linked StackOverflow question isn't related to 80-bit real at all.

@veelo
Copy link
Contributor Author

veelo commented Oct 1, 2019

@kyllingstad For what reasons was the x87 asm version removed from std.complex.expi? 029440c

@kyllingstad
Copy link
Member

kyllingstad commented Oct 7, 2019

@kyllingstad For what reasons was the x87 asm version removed from std.complex.expi? 029440c

See discussion in PR #559, in particular Don's comment

@ghost
Copy link

ghost commented Dec 7, 2019

Just noticed this - I wrote a similar PR yesterday, which is meanwhile merged. Hence, this PR can be closed. ("Having Fix - issue 19733 [...]" in the commit message would have maked the bot adding a link to this PR in bugzilla and I would have known of it earlier.)

@wilzbach wilzbach closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants