Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20159 - Make std.math.scalbn work in CTFE #7153

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Aug 23, 2019

No description provided.

@n8sh n8sh requested a review from ibuclaw as a code owner August 23, 2019 21:56
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
20159 enhancement Make std.math.scalbn work in CTFE

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7153"

@dlang-bot dlang-bot merged commit 5c9ccfc into dlang:master Aug 24, 2019
@WalterBright
Copy link
Member

Getting:

std\math.d(4566): Error: static assert:  `nanL == infL` is false

now in Azure pipelines (Windows_VisualD win32-ldc)

@WalterBright
Copy link
Member

@n8sh please fix.

@n8sh
Copy link
Member Author

n8sh commented Aug 24, 2019

That's the same problem I was seeing with FreeBSD. It seemed like CTFE didn't have 80 bit reals even though they existed at runtime. I'll try enabling the slow path for all platforms.

@n8sh
Copy link
Member Author

n8sh commented Aug 24, 2019

@WalterBright PR #7155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants