Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.range.enumerate should work with a non-mutable start index #7117

Merged
merged 1 commit into from
Jul 29, 2019
Merged

std.range.enumerate should work with a non-mutable start index #7117

merged 1 commit into from
Jul 29, 2019

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jul 29, 2019 

The deduced type for `Enumerator` could contain type modifier
(`const`, `immutable`), but the type was used directly as
a state variable.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 29, 2019 •
edited
Loading

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7117"

@thewilsonator
Copy link
Contributor

DIff is trivial, please target stable.

@Geod24 Geod24 changed the base branch from master to stable July 29, 2019 05:02
@Geod24
std.range.enumerate should work with a non-mutable start index
808cdd6 
The deduced type for `Enumerator` could contain type modifier
(`const`, `immutable`), but the type was used directly as
a state variable.
@Geod24 Geod24 force-pushed the enumerate-with-immutable-val branch from 14caa86 to 808cdd6 Compare July 29, 2019 05:02
@Geod24
Copy link
Member Author

Geod24 commented Jul 29, 2019

Targeting stable now

@dlang-bot dlang-bot merged commit 094e7c5 into dlang:stable Jul 29, 2019
@Geod24 Geod24 deleted the enumerate-with-immutable-val branch July 29, 2019 06:04
@jondegenhardt jondegenhardt mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrejMitrovic AndrejMitrovic AndrejMitrovic approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@JackStouffer JackStouffer Awaiting requested review from JackStouffer JackStouffer is a code owner

@wilzbach wilzbach Awaiting requested review from wilzbach wilzbach is a code owner

@PetarKirov PetarKirov Awaiting requested review from PetarKirov PetarKirov is a code owner

Assignees
No one assigned
Labels
auto-merge Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Geod24 @dlang-bot @thewilsonator @AndrejMitrovic