Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace D1 operator overloads with D2 operator overloads - Part 2 #7099

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Replace D1 operator overloads with D2 operator overloads - Part 2 #7099

merged 1 commit into from
Jul 4, 2019

Conversation

JinShil
Copy link
Contributor

@JinShil JinShil commented Jul 4, 2019

Follow up to #7098 (I missed one)

In support of dlang/dmd#10130

@JinShil JinShil requested a review from andralex as a code owner July 4, 2019 08:42
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7099"

@thewilsonator
Copy link
Contributor

Er that seems like an awful lot of build kite breakage.

@thewilsonator
Copy link
Contributor

Hmm, seems to be network issues.

@JinShil
Copy link
Contributor Author

JinShil commented Jul 4, 2019

All green now.

@dlang-bot dlang-bot merged commit 0fe3c16 into dlang:master Jul 4, 2019
@JinShil JinShil deleted the bitmanip_opCom branch July 4, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants