Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 19939 - std.format count width error #7068

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

shove70
Copy link
Contributor

@shove70 shove70 commented Jun 12, 2019

No description provided.

@shove70 shove70 requested a review from andralex as a code owner June 12, 2019 12:59
@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 12, 2019

Thanks for your pull request and interest in making D better, @shove70! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19939 normal std.format %13,3.2f does not count width correctly

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7068"

Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@quickfur quickfur added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jun 12, 2019
@shove70
Copy link
Contributor Author

shove70 commented Jun 13, 2019

@n8sh @quickfur, Thanks.

@thewilsonator
Copy link
Contributor

this should probably target stable.

@n8sh
Copy link
Member

n8sh commented Jun 17, 2019

Changing to target stable.

@n8sh n8sh changed the base branch from master to stable June 17, 2019 04:52
@thewilsonator thewilsonator removed the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jun 17, 2019
@dlang-bot dlang-bot merged commit 917d9ac into dlang:stable Jun 17, 2019
@shove70 shove70 deleted the patch-2 branch June 17, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants