Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.process.forkChild cannot be inlined #7059

Merged
merged 1 commit into from
Jun 5, 2019
Merged

std.process.forkChild cannot be inlined #7059

merged 1 commit into from
Jun 5, 2019

Conversation

JinShil
Copy link
Contributor

@JinShil JinShil commented Jun 5, 2019

This PR is in support of dlang/dmd#9978

forkChild is much too large to be inlined, but noone knew about it until now because std.process is not being compiled with the -inline flag and because of Issue 15110 which dlang/dmd#9978 attempts to fix.

See the output of the CIs in dlang/dmd#9978 for more information.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7059"

@dlang-bot dlang-bot merged commit c5664d4 into dlang:master Jun 5, 2019
@JinShil JinShil deleted the fix_15110 branch June 5, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants