-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ternary operator no longer promotes characters to integers [Part 2] #7043
Conversation
Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7043" |
//// chaining ranges of mixed character types gives `dchar` | ||
//static assert(is(typeof(r2.front) == dchar)); | ||
// chaining ranges of mixed character types gives `dchar` | ||
static assert(is(typeof(r2.front) == dchar)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSoulaimane @thewilsonator wasn't there consensus that the common type of any two types T
and U
is T
if U
is convertible to T
and U
if T
is convertible to U
? Or in other words, that the common type of char
and wchar
is wchar
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
byte b;
short s;
auto u = 0 ? b : s;
pragma(msg, typeof(u));
prints int.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was made withing the current practice of preemptive promotion even for ternary expressions. If/when that's going to change, it will affect more than just char
/wchar
but also the rest of the basic types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a DMD PR for that dlang/dmd#9943.
Re-enable test from #7041.