Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GDC] GCC9 last-minute fix: MinGW changes to get phobos to build #6980

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

jpf91
Copy link
Contributor

@jpf91 jpf91 commented Apr 27, 2019

This should hopefully contain only uncontroversial changes required to build phobos for MinGW. We have to hurry a bit to get this still into GCC-9, as that will likely be released next friday.

Related druntime PR: dlang/druntime#2586
Related GDC PR: D-Programming-GDC/gcc#14

ping @ibuclaw @redstar

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @jpf91! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6980"

@jpf91 jpf91 requested a review from ibuclaw as a code owner April 27, 2019 08:00
@jpf91 jpf91 changed the title [GDC] MinGW build fixes [GDC] GCC9 last-minute fix: MinGW changes to get phobos to build Apr 27, 2019
@dlang-bot dlang-bot merged commit daf0e4f into dlang:master Apr 27, 2019
@jpf91
Copy link
Contributor Author

jpf91 commented Apr 27, 2019

Thanks a lot everyone!

@jpf91 jpf91 deleted the mingw_minimal branch April 27, 2019 11:13
thewilsonator added a commit that referenced this pull request Apr 27, 2019
[dmd-cxx] GCC9 last-minute fix: MinGW changes to get phobos to build (backport #6980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants