Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3525 was fixed #6902

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

thewilsonator
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
3525 normal Override keyword & indirect inheritance of many interfaces

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6902"

@thewilsonator thewilsonator added documentation Trivial typos, formatting, comments labels Mar 13, 2019
@wilzbach
Copy link
Member

No merge commits in PRs please, try rebasing it instead.

@wilzbach
Copy link
Member

wilzbach commented May 9, 2019

No merge commits in PRs please, try rebasing it instead.

Fixed it up for you ;-)

@dlang-bot dlang-bot merged commit 39d3816 into dlang:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge documentation Trivial typos, formatting, comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants