Choose default compiler using path based priority. #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… results in dmd always being the default compiler. New Code: Do a path scan first, stopping when a compiler is found, and use that compiler instead. Result: The default compiler selected by dub will depend on how your path is setup, so that the first one found is selected, as oposed to always choosing compilers in a pre determined order.
|
@KevinBrogan Could you have a look at #895 ? Does it make sense to search dub's own directory first (before using the system path)? |
|
With #895 being resolved by searching for a configuration file beneath the executable, I'm wondering if this is a good idea. Is selecting programs based on PATH order common practice? My feeling is that this is rather obscure from the outside and using the "defaultCompiler" configuration field as an explicit alternative is already possible. |
|
Agreed with Sonke's reasoning here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Code: Do a compiler first scan, stopping when one is found, which results in dmd always being the default compiler.
New Code: Do a path scan first, stopping when a compiler is found, and use that compiler instead.
Result: The default compiler selected by dub will depend on how your path is setup, so that the first one found is selected, as oposed to always choosing compilers in a pre determined order.