Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all remaining args to the script for "dub [file].d" invocations. #866

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

s-ludwig
Copy link
Member

@s-ludwig s-ludwig commented Jun 7, 2016

Fixes #856.

@s-ludwig
Copy link
Member Author

s-ludwig commented Jun 7, 2016

@Geod24: Do you agree with this, or do you still have doubts or maybe an alternative?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 60.335% when pulling 90299db on issue856-shebang-args into 6cc5055 on master.

@Geod24
Copy link
Member

Geod24 commented Jun 8, 2016

However, this syntax is already there primarily to support shebang scripts, and AFAIK this is the only portable way to be able to pass parameters to the application.

I think that's a compelling argument, so the idea LGTM.
Could this be documented anywhere though ?

@s-ludwig
Copy link
Member Author

s-ludwig commented Jun 8, 2016

Yes, this definitely needs to be documented. I'll put a section at http://code.dlang.org/getting_started for now.

@s-ludwig s-ludwig merged commit b02c189 into master Jun 8, 2016
s-ludwig added a commit to dlang/dub-registry that referenced this pull request Jun 8, 2016
@s-ludwig s-ludwig deleted the issue856-shebang-args branch June 15, 2016 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants