-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualify NativePath members #2407
Conversation
Doesn't compile because Vibe.d has different qualifiers. |
Oops, thanks. Forgot to compile with unittests.
|
e230fd0
to
fcbed36
Compare
Ehh, I'm clueless about the CI errors. How can a simple adding of qualifiers break CI in any way when |
fcbed36
to
9697b76
Compare
How do you compile? |
How do I do that? I find no reference to vibe-core in top dub.sdl. Do you mean any of the
? |
Yes, but the problem is that the travis.sh script fails locally in on master and I find it really to hard to understand its output. We really need to do something about its output so it becomes obvious what are errors and not. |
I do
Grepping for vibe-core gives no hits. I don't understand what you mean. |
5160c06
to
e81aaf3
Compare
Modified and rebased but surprisingly fails in UT... |
We want to improve our path abstraction, which we can't do if we rely on Vibe's. One immediate improvement will be to add proper attributes to methods.
e81aaf3
to
c439917
Compare
Any clues why some platforms are passing and some are not? |
Older compilers don't run test, they just compile |
{ | ||
m_nodes = nodes; | ||
m_absolute = absolute; | ||
} | ||
|
||
/// Constructs a relative path with one path entry. | ||
this(PathEntry entry){ | ||
this(PathEntry entry) { pure nothrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken attributes
I recommend to go with something like #2821 instead. |
Trivial. Ready for merge.