Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prepare, lowerNonArrayAggregate and lowerArrayAggregate methods to statementsem #17011

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dchidindu5
Copy link
Contributor

Is there a need to update frontend.h or? @thewilsonator

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dchidindu5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17011"

@dchidindu5 dchidindu5 closed this Oct 17, 2024
@thewilsonator
Copy link
Contributor

No, they are all private (and most of them are extern(D)

@thewilsonator
Copy link
Contributor

Also did you mean to close this?

@dchidindu5
Copy link
Contributor Author

Also did you mean to close this?

I'll reopen it.

@dchidindu5 dchidindu5 reopened this Oct 17, 2024
@dchidindu5 dchidindu5 closed this Oct 17, 2024
@dchidindu5 dchidindu5 reopened this Oct 17, 2024
@dchidindu5
Copy link
Contributor Author

dchidindu5 commented Oct 19, 2024

Just saw this from the test suite @thewilsonator

 fail_compilation/test21939.d(11): Error: invalid `;` aggregate `Object` of type `Object`
  fail_compilation/test21939.d(11):        `foreach` works with input ranges (implementing `front` and `popFront`), aggregates implementing `opApply`, or the result of an aggregate's `.tupleof` property

@thewilsonator
Copy link
Contributor

That looks like you messed up the token passed to en error somewhere, but it is very strange that it only happens on a few platforms. Will take a look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants