Extract include func to dsymbolsem

[dchidindu5]

public bool addisdone = false; /// true if members have been added to scope
public bool onStack = false;

This variables were private before I had to change it to public because I encountered errors like undefined identifier onStack and addisdone`

Still working on them though

[dlang-bot]

Thanks for your pull request and interest in making D better, @dchidindu5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16970"

[thewilsonator]

also be sure to update attrib.h and frontend.h to reflect the changes made

[dchidindu5]

I'd do that once I'm done with the refactoring

[RazvanN7]

What's with this declaration? This shouldn't be here. AttribDeclaration defines the include method and all the children of AttribDeclaration override this method hence they have access to the array of declarations. I assume you actually wanted to have access to the decl field of AttribDeclaration? If you, you need to add a visitation method for AttribDeclaration.

[dchidindu5]

I don't totally understand this please

[dchidindu5]

can it be casted?
e.gLine 7539- cast(void) cache;

what about return null ?
e.g line 7535
Can it be removed entirely or to be casted?
@thewilsonator

[RazvanN7]

This is equivalent to:

if (sfd.errors || sfd.onStack)
{
        if (sfd.cached)
        {
            assert(!sfd.onStack);
            symbols= sfd.cache;
        }
}

Whereas what you want is:

if (sfd.errors || sfd.onStack)
{
      symbols = null;
      return;
}
if (sfd.cached)
{
       assert(!sfd.onStack);
       symbols= sfd.cache;
       return;
}

[thewilsonator]

Also symbols = sfd.cache; with proper spaces.

[dchidindu5]

What's the appropriate way to cast this
return condition.include(cdc._scope ? cdc._scope : sc) ? decl : cdc.elsedecl;

[RazvanN7]

This assignment doesn't make any sense. Delete it.

[RazvanN7]

This return is unnecessary.

[RazvanN7]

This return is not necessary.