Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable non-global template support for other compilers than DMD #10315

Closed
wants to merge 1 commit into from

Conversation

SSoulaimane
Copy link
Member

@SSoulaimane SSoulaimane commented Aug 17, 2019

Until GDC and LDC catch up.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10315"

@12345swordy
Copy link
Contributor

12345swordy commented Aug 17, 2019

cc @WalterBright @thewilsonator
Is this an reasonable compromise?

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but I don't see how this would be useful as the error message for the tests will be different for gdc and LDC, so they have to patch things anyhow. Also, LDC has already done this and released a beta.

@ibuclaw
Copy link
Member

ibuclaw commented Aug 18, 2019

Also, LDC has already done this and released a beta.

Citation?

@wilzbach
Copy link
Member

Also, LDC has already done this and released a beta.

Citation?

ldc-developers/ldc#3093 (comment)

With this. I was referring to the sentence before (this PR and its disabling of the feature).

@ibuclaw
Copy link
Member

ibuclaw commented Aug 18, 2019

@wilzbach - Thanks for clarifying. 'This' was rather ambiguous in your context. :-)

@Geod24
Copy link
Member

Geod24 commented Apr 3, 2021

The feature has been deprecated in v2.096.0: https://dlang.org/changelog/2.096.0.html#deprecate_dualcontext

@Geod24 Geod24 closed this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants