Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use extern(X) #3861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Bolpat
Copy link
Contributor

@Bolpat Bolpat commented Jun 27, 2024

Linkage is not a control-flow statement (such as if or while) and as with assert, pragma and many others, no space should be used between the keyword and the opening parenthesis.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ntrel
Copy link
Contributor

ntrel commented Jun 27, 2024

Makes sense as it is an attribute (though I'm used to seeing a space for it). I think all attributes with a parameter don't use a space, except align ( sometimes.
Related - version and debug sometimes don't have a space in the spec.

@Bolpat
Copy link
Contributor Author

Bolpat commented Jun 27, 2024

Makes sense as it is an attribute (though I'm used to seeing a space for it). I think all attributes with a parameter don't use a space, except align ( sometimes.

Honestly, I’m just testing the waters here. If this is being rejected, I’m not trying align either.

Related - version and debug sometimes don't have a space in the spec.

Related, but opposite. version and debug are conditional compilation / code-generation tools like static if and static foreach. Those are suggested by the D Style page to have a space.

@Bolpat Bolpat marked this pull request as ready for review June 27, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants