Copypaste-inline taggedalgebraic, try 2. Fixes #41? #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the taggedalgebraic hacks I've done in serialized to sidestep DMD bug https://issues.dlang.org/show_bug.cgi?id=21235 .
This is an update of #51 , this time with a backported version of
std_data_json
that has actually been tested and actually avoids the linker error from #41 .Note that these changes can never be upstreamed to
taggedalgebraic
, because they breakopEquals
so that it only barely even works for ourJSONValue
.This should be safe to revert once the DMD bug is fixed, but I wouldn't count on this happening soon: from what I've seen of it, it's an ugly one, and happens rarely to boot.