Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-compile linenoise on build #63

Merged
merged 4 commits into from
Feb 28, 2018

Conversation

wilzbach
Copy link
Member

Quite a simple idea to use the preBuildCommands hooks, but this should work on most Posix platforms as gcc is pretty universal. Of course, this isn't perfect and won't work on Windows.

@wilzbach
Copy link
Member Author

Sorry for the commit noise, but there were some issues with the way I checked in the module with git subtree - it is resolved now & I also removed the linenoise installation from Travis to test that the following will work for any Posix system:

dub fetch drepl && dub run drepl

(and maybe just run soon).

@wilzbach
Copy link
Member Author

CC @MartinNowak @ZombineDev - what's your opinion on this?

@wilzbach wilzbach requested a review from MartinNowak July 4, 2017 02:20
Copy link
Collaborator

@MartinNowak MartinNowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With most other header libraries, we've integrated building with the deimos project, seems reasonable here as well.
E.g. https://github.com/s-ludwig/libgit2/tree/0.19
and https://github.com/biozic/d2sqlite3/blob/master/dub.sdl
That also solves any version incompats.

@@ -0,0 +1,61 @@
/* linenoise.h -- guerrilla line editing library against the idea that a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to copy that file here instead of using the deimos project as dependency?

@wilzbach
Copy link
Member Author

wilzbach commented Feb 6, 2018

OK moved to D-Programming-Deimos/linenoise#5
With that, only a simple git tag should be needed :)

@MartinNowak MartinNowak merged commit 514436a into dlang-community:master Feb 28, 2018
@wilzbach wilzbach deleted the auto-compile3 branch April 2, 2018 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants