-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-compile linenoise on build #63
Conversation
4619afe
to
28f968d
Compare
Sorry for the commit noise, but there were some issues with the way I checked in the module with
(and maybe just run soon). |
CC @MartinNowak @ZombineDev - what's your opinion on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With most other header libraries, we've integrated building with the deimos project, seems reasonable here as well.
E.g. https://github.com/s-ludwig/libgit2/tree/0.19
and https://github.com/biozic/d2sqlite3/blob/master/dub.sdl
That also solves any version incompats.
deimos/linenoise.di
Outdated
@@ -0,0 +1,61 @@ | |||
/* linenoise.h -- guerrilla line editing library against the idea that a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to copy that file here instead of using the deimos project as dependency?
OK moved to D-Programming-Deimos/linenoise#5 |
fd58dfb
to
77eac8c
Compare
Quite a simple idea to use the
preBuildCommands
hooks, but this should work on most Posix platforms asgcc
is pretty universal. Of course, this isn't perfect and won't work on Windows.dub fetch