warning: large size difference between variants --> node/src/cli.rs:73:1 | 73 | / pub enum Subcommand { 74 | | /// Key management cli utilities 75 | | #[clap(subcommand)] 76 | | Key(sc_cli::KeySubcommand), | | -------------------------- the second-largest variant contains at least 264 bytes ... | 115 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 488 bytes 116 | | } | |_^ the entire enum is at least 488 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 115 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: function `config` is never used --> node/src/chain_spec/mainnet.rs:100:8 | 100 | pub fn config(parachain_id: ParaId) -> ChainSpec { | ^^^^^^

warning: function `genesis` is never used --> node/src/chain_spec/mainnet.rs:63:8 | 63 | pub fn genesis( | ^^^^^^^

warning: function `main_genesis` is never used --> node/src/chain_spec/mainnet.rs:35:4 | 35 | fn main_genesis( | ^^^^^^^^^^^^

warning: constant `SAFE_XCM_VERSION` is never used --> node/src/chain_spec/mod.rs:65:11 | 65 | pub const SAFE_XCM_VERSION: u32 = xcm::prelude::XCM_VERSION; | ^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unneeded `return` statement --> runtime/main/src/lib.rs:860:13 | 860 | return (list, storage_info) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 860 | (list, storage_info) |

warning: this operation has no effect --> runtime/main/src/lib.rs:597:37 | 597 | pub const MinimalBid: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/main/src/lib.rs:404:45 | 404 | pub const DataDepositPerByte: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/main/src/lib.rs:386:46 | 386 | pub const PreimageBaseDeposit: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/main/src/lib.rs:261:45 | 261 | pub const TransactionByteFee: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/main/src/lib.rs:243:44 | 243 | pub const MinVestedTransfer: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/main/src/lib.rs:219:45 | 219 | pub const ExistentialDeposit: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op = note: `#[warn(clippy::identity_op)]` on by default

warning: this match could be replaced by its body itself --> runtime/main/src/lib.rs:113:9 | 113 | / match call { 114 | | // These modules are not allowed to be called by transactions: 115 | | // Other modules should works: 116 | | _ => true, 117 | | } | |_________^ help: consider using the match body instead: `true` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` on by default

warning: redundant closure --> runtime/main/src/xcm_config.rs:202:34 | 202 | calls.iter().all(|call| Self::allow_base_call(call)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Self::allow_base_call` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure --> runtime/main/src/xcm_config.rs:199:34 | 199 | calls.iter().all(|call| Self::allow_base_call(call)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Self::allow_base_call` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: using `clone` on type `MultiLocation` which implements the `Copy` trait --> runtime/main/src/xcm_config.rs:97:18 | 97 | Some(location.clone()) | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: unneeded `return` statement --> runtime/dev/src/lib.rs:833:13 | 833 | return (list, storage_info) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 833 | (list, storage_info) |

warning: this operation has no effect --> runtime/dev/src/lib.rs:547:37 | 547 | pub const MinimalBid: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:395:45 | 395 | pub const DataDepositPerByte: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:377:46 | 377 | pub const PreimageBaseDeposit: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:245:44 | 245 | pub const MinVestedTransfer: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:191:45 | 191 | pub const ExistentialDeposit: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op = note: `#[warn(clippy::identity_op)]` on by default

warning: this function has too many arguments (9/7) --> node/service/src/parachain.rs:298:1 | 298 | #[sc_tracing::logging::prefix_logs_with("Parachain")] | ^---------------------------------------------------- | | | _in this procedural macro expansion | | 299 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>( 300 | | parachain_config: Configuration, 301 | | polkadot_config: Configuration, ... | 308 | | hwbench: Option<sc_sysinfo::HwBench>, 309 | | ) -> sc_service::error::Result<(TaskManager, Arc<ParachainClient<RuntimeApi>>)> | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this expression creates a reference which is immediately dereferenced by the compiler --> node/service/src/parachain.rs:254:13 | 254 | &config, | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: very complex type used. Consider factoring parts into `type` definitions --> node/service/src/parachain.rs:196:6 | 196 | ) -> Result< | ______^ 197 | | PartialComponents< 198 | | ParachainClient<RuntimeApi>, 199 | | ParachainBackend, ... | 209 | | sc_service::Error, 210 | | > | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: this function has too many arguments (12/7) --> node/service/src/parachain.rs:120:1 | 120 | / pub fn build_open_consensus<RuntimeApi>( 121 | | para_id: ParaId, 122 | | lighthouse_account: AccountId, 123 | | client: Arc<ParachainClient<RuntimeApi>>, ... | 132 | | _force_authoring: bool, 133 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error> | |__________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait --> node/service/src/parachain.rs:114:9 | 114 | registry.clone(), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions --> node/service/src/dev.rs:227:6 | 227 | ) -> Result< | ______^ 228 | | ( 229 | | TaskManager, 230 | | Arc<FullClient<Runtime>>, ... | 234 | | ServiceError, 235 | | > | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: this expression creates a reference which is immediately dereferenced by the compiler --> node/service/src/dev.rs:135:13 | 135 | &config, | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions --> node/service/src/dev.rs:84:6 | 84 | ) -> Result< | ______^ 85 | | sc_service::PartialComponents< 86 | | FullClient<Runtime>, 87 | | FullBackend, ... | 101 | | ServiceError, 102 | | > | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: unneeded `return` statement --> vendor/pallet-xcm/src/lib.rs:2290:17 | 2290 | / return match maybe_notify { 2291 | | Some((pallet_index, call_index)) => { 2292 | | // This is a bit horrible, but we happen to know that the `Call` will 2293 | | // be built by `(pallet_index: u8, call_index: u8, QueryId, Response)`. ... | 2356 | | } 2357 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 2290 ~ match maybe_notify { 2291 + Some((pallet_index, call_index)) => { 2292 + // This is a bit horrible, but we happen to know that the `Call` will 2293 + // be built by `(pallet_index: u8, call_index: u8, QueryId, Response)`. 2294 + // So we just encode that and then re-encode to a real Call. 2295 + let bare = (pallet_index, call_index, query_id, response); 2296 + if let Ok(call) = bare.using_encoded(|mut bytes| { 2297 + <T as Config>::RuntimeCall::decode(&mut bytes) 2298 + }) { 2299 + Queries::<T>::remove(query_id); 2300 + let weight = call.get_dispatch_info().weight; 2301 + if weight.any_gt(max_weight) { 2302 + let e = Event::NotifyOverweight { 2303 + query_id, 2304 + pallet_index, 2305 + call_index, 2306 + actual_weight: weight, 2307 + max_budgeted_weight: max_weight, 2308 + }; 2309 + Self::deposit_event(e); 2310 + return Weight::zero(); 2311 + } 2312 + let dispatch_origin = Origin::Response(origin).into(); 2313 + match call.dispatch(dispatch_origin) { 2314 + Ok(post_info) => { 2315 + let e = Event::Notified { 2316 + query_id, 2317 + pallet_index, 2318 + call_index, 2319 + }; 2320 + Self::deposit_event(e); 2321 + post_info.actual_weight 2322 + } 2323 + Err(error_and_info) => { 2324 + let e = Event::NotifyDispatchError { 2325 + query_id, 2326 + pallet_index, 2327 + call_index, 2328 + }; 2329 + Self::deposit_event(e); 2330 + // Not much to do with the result as it is. It's up to the 2331 + // parachain to ensure that the message makes sense. 2332 + error_and_info.post_info.actual_weight 2333 + } 2334 + } 2335 + .unwrap_or(weight) 2336 + } else { 2337 + let e = Event::NotifyDecodeFailed { 2338 + query_id, 2339 + pallet_index, 2340 + call_index, 2341 + }; 2342 + Self::deposit_event(e); 2343 + Weight::zero() 2344 + } 2345 + } 2346 + None => { 2347 + let e = Event::ResponseReady { 2348 + query_id, 2349 + response: response.clone(), 2350 + }; 2351 + Self::deposit_event(e); 2352 + let at = frame_system::Pallet::<T>::current_block_number(); 2353 + let response = response.into(); 2354 + Queries::<T>::insert(query_id, QueryStatus::Ready { response, at }); 2355 + Weight::zero() 2356 + } 2357 ~ } |

warning: unneeded `return` statement --> vendor/pallet-xcm/src/lib.rs:2159:9 | 2159 | return true; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 2159 - return true; 2159 + true |

warning: needlessly taken reference of both operands --> vendor/pallet-xcm/src/lib.rs:1772:56 | 1772 | if let Some(index) = q.iter().position(|i| &i.0 == &versioned_dest) { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default help: use the values directly | 1772 | if let Some(index) = q.iter().position(|i| i.0 == versioned_dest) { | ~~~ ~~~~~~~~~~~~~~

warning: local variable doesn't need to be boxed here --> vendor/pallet-xcm/src/lib.rs:1360:9 | 1360 | assets: Box<VersionedMultiAssets>, | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local

warning: local variable doesn't need to be boxed here --> vendor/pallet-xcm/src/lib.rs:1284:9 | 1284 | assets: Box<VersionedMultiAssets>, | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local = note: `#[warn(clippy::boxed_local)]` on by default

warning: useless conversion to the same type: `u64` --> vendor/pallet-xcm/src/lib.rs:1224:9 | 1224 | Self::do_new_query(responder, None, timeout, match_querier).into() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Self::do_new_query(responder, None, timeout, match_querier)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: large size difference between variants --> vendor/pallet-xcm/src/lib.rs:510:5 | 510 | / pub enum QueryStatus<BlockNumber> { 511 | | /// The query was sent but no response has yet been received. 512 | | / Pending { 513 | | | /// The `QueryResponse` XCM must have this origin to be considered a reply for this 514 | | | /// query. 515 | | | responder: VersionedMultiLocation, ... | | 520 | | | timeout: BlockNumber, 521 | | | }, | | |_________- the largest variant contains at least 1299 bytes 522 | | /// The query is for an ongoing version notification subscription. 523 | | / VersionNotifier { 524 | | | origin: VersionedMultiLocation, 525 | | | is_active: bool, 526 | | | }, | | |_________- the second-largest variant contains at least 649 bytes ... | 531 | | }, 532 | | } | |_______^ the entire enum is at least 1299 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant help: consider boxing the large fields to reduce the total size of the enum | 518 | maybe_match_querier: Box<Option<VersionedMultiLocation>>, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: large size difference between variants --> vendor/pallet-xcm/src/lib.rs:274:5 | 274 | / pub enum Event<T: Config> { 275 | | /// Execution of an XCM message was attempted. 276 | | Attempted { outcome: xcm::latest::Outcome }, 277 | | /// A XCM message was sent. 278 | | / Sent { 279 | | | origin: MultiLocation, 280 | | | destination: MultiLocation, 281 | | | message: Xcm<()>, 282 | | | message_id: XcmHash, 283 | | | }, | | |_________- the second-largest variant contains at least 1328 bytes ... | 398 | | / InvalidQuerier { 399 | | | origin: MultiLocation, 400 | | | query_id: QueryId, 401 | | | expected_querier: MultiLocation, 402 | | | maybe_actual_querier: Option<MultiLocation>, 403 | | | }, | | |_________- the largest variant contains at least 1952 bytes ... | 434 | | }, 435 | | } | |_______^ the entire enum is at least 0 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 402 | maybe_actual_querier: Box<Option<MultiLocation>>, | ~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: useless conversion to the same type: `[u8; 32]` --> vendor/pallet-xcm/src/benchmarking.rs:78:46 | 78 | AccountId32 { network: None, id: recipient.into() }.into(); | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recipient` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `[u8; 32]` --> vendor/pallet-xcm/src/benchmarking.rs:58:46 | 58 | AccountId32 { network: None, id: recipient.into() }.into(); | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recipient` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: unneeded unit expression --> vendor/pallet-xcm/src/lib.rs:2053:17 | 2053 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default

warning: this match could be written as a `let` statement --> frame/lighthouse/src/lib.rs:215:9 | 215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? { 216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))), 217 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` on by default help: consider using a `let` statement | 215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?; 216 + Some(Err(sp_inherents::Error::Application(Box::from(o)))) |

warning: redundant field names in struct initialization --> frame/lighthouse/src/lib.rs:128:17 | 128 | lighthouse: lighthouse, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default

warning: this let-binding has unit value --> frame/liability/src/lib.rs:145:26 | 145 | #[pallet::weight(200_000)] | ^^^^^^^ help: omit the `let` binding: `200_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/liability/src/lib.rs:117:26 | 117 | #[pallet::weight(200_000)] | ^^^^^^^ help: omit the `let` binding: `200_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: binary comparison to literal `Option::None` --> frame/liability/src/lib.rs:156:17 | 156 | <ReportOf<T>>::get(index) == None, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none = note: `#[warn(clippy::partialeq_to_none)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/liability/src/lib.rs:145:26 | 145 | #[pallet::weight(200_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/liability/src/lib.rs:117:26 | 117 | #[pallet::weight(200_000)] | ^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: this `else { if .. }` block can be collapsed --> frame/liability/src/signed.rs:76:16 | 76 | } else { | ________________^ 77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price { 78 | | Ok(()) 79 | | } else { 80 | | Err("reserved less than expected")? 81 | | } 82 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price { 77 + Ok(()) 78 + } else { 79 + Err("reserved less than expected")? 80 + } |

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:84:26 | 84 | #[pallet::weight(50_000)] | ^^^^^^ help: omit the `let` binding: `50_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:73:26 | 73 | #[pallet::weight(50_000)] | ^^^^^^ help: omit the `let` binding: `50_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:85:16 | 85 | pub fn set_source( | ^^^^^^^^^^ help: omit the `let` binding: `set_source;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:74:16 | 74 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^^^^^^ help: omit the `let` binding: `create;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/digital-twin/src/lib.rs:84:26 | 84 | #[pallet::weight(50_000)] | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/digital-twin/src/lib.rs:73:26 | 73 | #[pallet::weight(50_000)] | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/digital-twin/src/lib.rs:85:16 | 85 | pub fn set_source( | ^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/digital-twin/src/lib.rs:74:16 | 74 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^^^^^^

warning: use of deprecated struct `pallet::_::Store`: Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023. Check https://github.com/paritytech/substrate/pull/13535 for more details. --> frame/digital-twin/src/lib.rs:66:6 | 66 | #[pallet::generate_store(pub(super) trait Store)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: this let-binding has unit value --> frame/rws/src/lib.rs:404:26 | 404 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:376:26 | 376 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:357:26 | 357 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:335:26 | 335 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:292:26 | 292 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:405:16 | 405 | pub fn start_auction( | ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:377:16 | 377 | pub fn set_subscription( | ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:358:16 | 358 | pub fn set_oracle( | ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:336:16 | 336 | pub fn set_devices( | ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:293:16 | 293 | pub fn bid( | ^^^ help: omit the `let` binding: `bid;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:261:16 | 261 | pub fn call( | ^^^^ help: omit the `let` binding: `call;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this expression creates a reference which is immediately dereferenced by the compiler --> frame/rws/src/lib.rs:452:60 | 452 | T::AuctionCurrency::slash_reserved(&subscription_id, auction.best_price); | ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this let-binding has unit value --> frame/rws/src/lib.rs:409:13 | 409 | let _ = ensure_root(origin)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:320:38 | 320 | auction.best_price = amount.clone(); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:318:54 | 318 | T::AuctionCurrency::reserve(&sender, amount.clone())?; | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:314:38 | 314 | auction.best_price = amount.clone(); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: this expression creates a reference which is immediately dereferenced by the compiler --> frame/rws/src/lib.rs:312:47 | 312 | T::AuctionCurrency::unreserve(&winner, auction.best_price); | ^^^^^^^ help: change this to: `winner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:311:54 | 311 | T::AuctionCurrency::reserve(&sender, amount.clone())?; | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:404:26 | 404 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:376:26 | 376 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:357:26 | 357 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:335:26 | 335 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:292:26 | 292 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:405:16 | 405 | pub fn start_auction( | ^^^^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:377:16 | 377 | pub fn set_subscription( | ^^^^^^^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:358:16 | 358 | pub fn set_oracle( | ^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:336:16 | 336 | pub fn set_devices( | ^^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:293:16 | 293 | pub fn bid( | ^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:261:16 | 261 | pub fn call( | ^^^^

warning: use of deprecated struct `pallet::_::Store`: Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023. Check https://github.com/paritytech/substrate/pull/13535 for more details. --> frame/rws/src/lib.rs:235:6 | 235 | #[pallet::generate_store(pub(super) trait Store)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: this let-binding has unit value --> frame/digital-twin-v2/src/lib.rs:141:26 | 141 | #[pallet::weight(50_000)] | ^^^^^^ help: omit the `let` binding: `50_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin-v2/src/lib.rs:87:26 | 87 | #[pallet::weight(50_000)] | ^^^^^^ help: omit the `let` binding: `50_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin-v2/src/lib.rs:142:16 | 142 | pub fn remove( | ^^^^^^ help: omit the `let` binding: `remove;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin-v2/src/lib.rs:88:16 | 88 | pub fn insert( | ^^^^^^ help: omit the `let` binding: `insert;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: usage of `contains_key` followed by `insert` on a `BTreeMap` --> frame/digital-twin-v2/src/lib.rs:106:21 | 106 | / if digital_twin.data.contains_key(&key.clone()) { 107 | | digital_twin.data.insert(key.clone(), value.clone()); 108 | | Self::deposit_event(Event::DigitalTwinRecordUpdated( 109 | | sender, ... | 134 | | } 135 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 106 ~ match digital_twin.data.entry(key.clone()) { 107 + std::collections::btree_map::Entry::Occupied(mut e) => { 108 + e.insert(value.clone()); 109 + Self::deposit_event(Event::DigitalTwinRecordUpdated( 110 + sender, 111 + digital_twin.count, 112 + key, 113 + value, 114 + )); 115 + 116 + // TODO: callback 117 + 118 + Ok(().into()) 119 + } 120 + std::collections::btree_map::Entry::Vacant(e) => { 121 + if digital_twin.count < T::MaxCount::get() { 122 + e.insert(value.clone()); 123 + digital_twin.count += 1; 124 + Self::deposit_event(Event::DigitalTwinRecordInserted( 125 + sender, 126 + digital_twin.count, 127 + key, 128 + value, 129 + )); 130 + 131 + // TODO: callback 132 + 133 + Ok(().into()) 134 + } else { 135 + Err("Max count!".into()) 136 + } 137 + } 138 + } |

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/digital-twin-v2/src/lib.rs:141:26 | 141 | #[pallet::weight(50_000)] | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/digital-twin-v2/src/lib.rs:87:26 | 87 | #[pallet::weight(50_000)] | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/digital-twin-v2/src/lib.rs:142:16 | 142 | pub fn remove( | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/digital-twin-v2/src/lib.rs:88:16 | 88 | pub fn insert( | ^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: this `else { if .. }` block can be collapsed --> frame/digital-twin-v2/src/lib.rs:118:28 | 118 | } else { | ____________________________^ 119 | | if digital_twin.count < T::MaxCount::get() { 120 | | digital_twin.data.insert(key.clone(), value.clone()); 121 | | digital_twin.count += 1; ... | 134 | | } 135 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 118 ~ } else if digital_twin.count < T::MaxCount::get() { 119 + digital_twin.data.insert(key.clone(), value.clone()); 120 + digital_twin.count += 1; 121 + Self::deposit_event(Event::DigitalTwinRecordInserted( 122 + sender, 123 + digital_twin.count, 124 + key, 125 + value, 126 + )); 127 + 128 + // TODO: callback 129 + 130 + Ok(().into()) 131 + } else { 132 + Err("Max count!".into()) 133 + } |

warning: the borrowed expression implements the required traits --> frame/datalog/src/lib.rs:152:50 | 152 | let mut idx = DatalogIndex::<T>::get(&account); | ^^^^^^^^ help: change this to: `account` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: unused variable: `win` --> frame/datalog/src/weights.rs:13:14 | 13 | fn erase(win: u64) -> Weight { | ^^^ help: if this is intentional, prefix it with an underscore: `_win` | = note: `#[warn(unused_variables)]` on by default

warning: this let-binding has unit value --> frame/launch/src/lib.rs:58:26 | 58 | #[pallet::weight(500_000)] | ^^^^^^^ help: omit the `let` binding: `500_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/launch/src/lib.rs:58:26 | 58 | #[pallet::weight(500_000)] | ^^^^^^^ | = note: `#[warn(deprecated)]` on by default