Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip out BOM when reading text files #1584

Closed
reckart opened this issue May 7, 2024 · 0 comments
Closed

Strip out BOM when reading text files #1584

reckart opened this issue May 7, 2024 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module-io.text
Milestone
2.5.0

Comments

@reckart
Copy link
Member

reckart commented May 7, 2024

Is your feature request related to a problem? Please describe.
When reading a text file using the TextReader, if the file contains a BOM at the start, that BOM ends up in the CAS. Typically, this is not what we want.

Describe the solution you'd like
By default remove the BOM, but allow to keep it using a parameter.
@reckart reckart added ⭐️ Enhancement New feature or request Module-io.text labels May 7, 2024
@reckart reckart added this to the 2.5.0 milestone May 7, 2024
@reckart reckart self-assigned this May 7, 2024
reckart added a commit that referenced this issue May 7, 2024
@reckart
#1584 - Strip out BOM when reading text files
edca174 
- Remove BOM by default
- Parameter to allow keeping it
- Added test
reckart added a commit that referenced this issue May 7, 2024
@reckart
#1584 - Strip out BOM when reading text files
f6d8996 
- Remove BOM by default
- Parameter to allow keeping it
- Added test
reckart added a commit that referenced this issue May 7, 2024
@reckart
Merge pull request #1585 from dkpro/feature/1584-Strip-out-BOM-when-r…
7bca2cf 
…eading-text-files

#1584 - Strip out BOM when reading text files
@reckart reckart closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this to Done in Kanban Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module-io.text
Projects
Kanban
Status: Done
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@reckart