Skip to content

Commit

Permalink
Synchronize zonal and regional node pool auto_upgrade default
Browse files Browse the repository at this point in the history
The regional and zonal node pool configurations had different defaults
for `auto_upgrade`. We prefer auto-upgrading node pools in general, and
moreover having different defaults for regional and zonal node pools is
very surprising.

This commit reconciles the difference by changing the zonal node pool
auto_upgrade default to true.
  • Loading branch information
adrienthebo committed Mar 12, 2019
1 parent 2162779 commit 2db1bcd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cluster_zonal.tf
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ resource "google_container_node_pool" "zonal_pools" {

management {
auto_repair = "${lookup(var.node_pools[count.index], "auto_repair", true)}"
auto_upgrade = "${lookup(var.node_pools[count.index], "auto_upgrade", false)}"
auto_upgrade = "${lookup(var.node_pools[count.index], "auto_upgrade", true)}"
}

node_config {
Expand Down

0 comments on commit 2db1bcd

Please sign in to comment.