fix: fix wrong parameter for resolveControllerRef (kubeflow#1583)

djwhatle · Jul 21, 2022 · f5c5dea · f5c5dea
1 parent 8c6eab2
commit f5c5dea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/common/util/reconciler.go b/pkg/common/util/reconciler.go
@@ -98,7 +98,7 @@ func OnDependentUpdateFunc(jc *common.JobController) func(updateEvent event.Upda
 
 		if controllerRefChanged && oldControllerRef != nil {
 			// The ControllerRef was changed. Sync the old controller, if any.
-			if job := resolveControllerRef(jc, oldObj.GetName(), oldControllerRef); job != nil {
+			if job := resolveControllerRef(jc, oldObj.GetNamespace(), oldControllerRef); job != nil {
 				logger.Infof("pod/service controller ref updated: %v, %v", newObj, oldObj)
 				return true
 			}

diff --git a/pkg/common/util/reconciler_generic.go b/pkg/common/util/reconciler_generic.go
@@ -91,7 +91,7 @@ func OnDependentUpdateFuncGeneric(jc *common.JobController) func(updateEvent eve
 
 		if controllerRefChanged && oldControllerRef != nil {
 			// The ControllerRef was changed. Sync the old controller, if any.
-			if job := resolveControllerRef(jc, oldObj.GetName(), oldControllerRef); job != nil {
+			if job := resolveControllerRef(jc, oldObj.GetNamespace(), oldControllerRef); job != nil {
 				logger.Infof("%s controller ref updated: %v, %v", kind, newObj, oldObj)
 				return true
 			}