Performance Improvement 1 - Reduce number of pure calls. #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_ignored_block_opening(config, item)
andis_safe_closing_tag(config, item)
are each called multiple times in indent.py with the same parameters. This can be deduplicated.(Note I've changed the block
with executor_cls(max_workers=worker_count) as exe:
in__init__.py
to be serial to make the profiler work.Before:
is_ignored_block_opening (With children): 12.4% of all the time, 61562x calls
is_safe_closing_tag (With children): 6.24% of all the time, 33139x calls
Concrete data:
After
is_ignored_block_opening (With children): 4.73% of all the time, 20622x calls
is_safe_closing_tag (With children): 4.61% of all the time, 20941x calls
Concrete data: