Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CancelWithErr mechanism #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neilotoole
Copy link

We already have a Stream.ShutdownWithErr mechanism, which propagates a custom error.

There's also a Stream.Cancel method. However, there should be a Stream.CancelWithErr method to allow propagation of a custom error.

For example, let's say I'm reading from an http response, and writing the bytes to a stream. If there's an error reading the response, I specifically want to Cancel the stream (as opposed to calling Shutdown). But, any clients of the stream will just receive a generic ErrCanceled, which is not super helpful. I want to be able to propagate the http error back to the stream clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant