-
Notifications
You must be signed in to change notification settings - Fork 149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks like you've been quite busy. Had a busy weekend and didn't have much time to look into it, but hopefully will in the next few days.
Changes in your notes make sense, any breaking changes?
|
||
A beautiful way to manage your Hashicorp Vault | ||
|
||
![](http://i.imgur.com/COBxk3m.gif) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome gif!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took some ideas from https://github.com/matiassingers/awesome-readme
Hopefully I haven't introduced any regression. All functionalities seem to be left intact. The only noticeable change from a dev point of view is in the browserHistory/hashHistory difference, but as long as you import Give it try when you have some time and let me know if you notice anything wrong |
@msessa So, the standalone app fails when using self-signed TLS certificates with Vault. Would it make sense to perhaps include a checkbox that would do what NODE_TLS_REJECT_UNAUTHORIZED=0 does? The App prompts to, what I am assuming, add the self-signed cert to the OSX keychain. However, allowing it to do that does nothing. Vault shows TLS error: The only way to make this work is to install the self-signed cert on OSX manually and manually allow trust. It then works... but, kind of a hassle. |
@fia5000 Thanks for reporting this! I'll look into it asap |
@fia5000 The TLS issue has been fixed. The app now presents a dialog to ignore the TLS certificate error: |
@msessa Cool! I ran the app with I will chalk it up to something wrong that I probably did until you release a new test packaged build on your forked repo perhaps. |
I used electron-builder for packaging and publishing. If you look into
Or simply try I've also updated the builds on https://github.com/cotdsa/vault-ui/releases |
@msessa Excellent, sir! All works well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msessa Dove through the code, did a very quick overview of functional changes which seem to be transparent enough to the normal use case. I also ran the UI and didn't see any issues.
As far as I'm concerned, LGTM.
This PR introduces the necessary changes to make vault-ui a cross-platform desktop application.
Based on Electron, the desktop version will communicate directly with any vault server, regardless of the lack of CORS headers.
Apart from a few exceptions, any existing code will work seamlessly between web and desktop versions.
You can test it by running
Notable changes:
WEBPACK_DEF_TARGET_WEB
boolean define allows to differentiate behaviour between web/desktop versionsbrowserHistory
while desktop version useshashHistory
. (see VaultUtils.jsx:5)/vaultui
REST endpoint to communicate server-configured defaults to the client